mirrors/rbenv-ruby-build
1
0
Fork 0
mirror of https://github.com/rbenv/ruby-build.git synced 2025-01-01 14:44:48 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix commands printed when TMPDIR is empty

Browse source
This commit is contained in:
Mislav Marohnić 2023-11-08 23:50:22 +01:00
parent bb18f12e64
commit c4f811a23d
No known key found for this signature in database
2 changed files with 29 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
bin/ruby-build
View file

@ -110,10 +110,9 @@ colorize() {
print_command() { print_command() {
local arg local arg
local tmpdir="${TMPDIR%/}"
for arg; do for arg; do
arg="${arg//$tmpdir\//\$TMPDIR/}" [ "${#TMPDIR}" -le 1 ] || arg="${arg//$TMP\//\$TMPDIR/}"
arg="${arg//$HOME\//\$HOME/}" [ "${#HOME}" -le 1 ] || arg="${arg//$HOME\//\$HOME/}"
case "$arg" in case "$arg" in
*\'* | *\$* ) *\'* | *\$* )
printf ' "%s"' "$arg" ;; printf ' "%s"' "$arg" ;;

27
test/output.bats Normal file
View file

@ -0,0 +1,27 @@
#!/usr/bin/env bats
load test_helper
@test "print_command" {
mkdir -p "$TMP"
cat <<EOF > "$TMP"/definition
print_command ./configure --prefix="\$PREFIX_PATH" --arg='with spaces'
EOF
# substitute $TMPDIR in command invocations
TMPDIR="/tmp/" run ruby-build "$TMP"/definition /tmp/path/to/prefix
assert_output " ./configure \"--prefix=\$TMPDIR/path/to/prefix\" '--arg=with spaces'"
# doesn't substitute TMPDIR if it didn't come from user's environment
TMPDIR="" run ruby-build "$TMP"/definition /tmp/path/to/prefix
assert_output " ./configure --prefix=/tmp/path/to/prefix '--arg=with spaces'"
cat <<EOF > "$TMP"/definition
print_command install --bindir="$TMP"/home/.local/bin
EOF
# substitute $HOME in command invocations
HOME="$TMP"/home TMPDIR="" run ruby-build "$TMP"/definition /tmp/path/to/prefix
assert_output " install \"--bindir=\$HOME/.local/bin\""
# do not substitute $HOME if it's root path
HOME="/" TMPDIR="" run ruby-build "$TMP"/definition /tmp/path/to/prefix
assert_output " install --bindir=${TMP}/home/.local/bin"
}