Treat exec from subshell as if forked

This removes weird behaviour when optimising the last command.
In particular SHLVL is correct from a subshell executed as the last
command.
This commit is contained in:
Peter Stephenson 2014-11-02 15:29:06 +00:00
parent 6a29f66f8a
commit 023c2236e1
3 changed files with 23 additions and 1 deletions

View File

@ -1,3 +1,9 @@
2014-11-02 Peter Stephenson <p.w.stephenson@ntlworld.com>
* 33591: Src/exec.c, Test/D04parameter.ztst: don't treat an exec
within an subshell as an exec of the parent shell even if about
to exit. Fixes incorrect SHLVL in subshell.
2014-10-31 Oliver Kiddle <opk@zsh.org>
* unposted: Src/jobs.c: quash compiler warning

View File

@ -2995,6 +2995,15 @@ execcmd(Estate state, int input, int output, int how, int last1)
* Note that any form of exec means that the subshell is fake *
* (but we may be in a subshell already). */
is_exec = 1;
/*
* If we are in a subshell environment anyway, say we're forked,
* even if we're actually not forked because we know the
* subshell is exiting. This ensures SHLVL reflects the current
* shell, and also optimises out any save/restore we'd need to
* do if we were returning to the main shell.
*/
if (type == WC_SUBSH)
forked = 1;
}
if ((esglob = !(cflags & BINF_NOGLOB)) && args && htok) {

View File

@ -1548,7 +1548,7 @@
foo=
print ${foo:wq}
print ${:wq}
0:Empty parameter shouldn't cause modifiers to crash the shell
0:Empty parameter should not cause modifiers to crash the shell
>
>
@ -1656,3 +1656,10 @@
>h:i
>j,k
>l
SHLVL=1
$ZTST_testdir/../Src/zsh -c 'echo $SHLVL'
$ZTST_testdir/../Src/zsh -c '(echo $SHLVL)'
0:SHLVL appears sensible when about to exit shell
>2
>2