From 2d3b3510a80046cd4222bf9c515afc90bdf76418 Mon Sep 17 00:00:00 2001 From: Peter Stephenson Date: Thu, 26 Apr 2018 09:42:25 +0100 Subject: [PATCH] c.f. 42726: Back off fg and bg tests. This is too hard to make robust. Problems include - Reading input in different places causes lines to appear and disappear - There is no easy way to sequence the asynchronous operations following bg. - Response to job control of user commands on some OSes (MacOS, for example) is unpredicatble. --- ChangeLog | 5 +++++ Test/W02jobs.ztst | 42 ------------------------------------------ 2 files changed, 5 insertions(+), 42 deletions(-) diff --git a/ChangeLog b/ChangeLog index f540a1f59..0bf5502b6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2018-04-26 Peter Stephenson + + * c.f. 42726: Test/W02jobs.ztst: Back off fg and bg tests as they + are currently too hard to make robust. + 2018-04-25 Daniel Shahaf * unposted: Src/exec.c: Correct process substitution buffer diff --git a/Test/W02jobs.ztst b/Test/W02jobs.ztst index 6d5a41f00..1e7ac76c6 100644 --- a/Test/W02jobs.ztst +++ b/Test/W02jobs.ztst @@ -191,48 +191,6 @@ *>\[2] ? interrupt*sleep* *>\[1] ? kill*sleep* - zpty_start - zpty_input $'dc 2>/dev/null\n1\np\n' - zpty_line - zpty_input $'1\n+\np\nq\n' - zpty_stop -0:Sanity check of "ed" as foreground process -*>1 -*>2 -F:This test checks we can run the simple calculator dc as a way of testing -F:user interaction for later job control tests . The test itself is -F:trivial; its failure may simply indicate our test methodology does not -F:work on this system. - - zpty_start - zpty_input $'dc 2>/dev/null\n1\np\n' - zpty_line - zpty_input $'\C-z' - zpty_input 'fg' - zpty_input $'1\n+\np\nq\n' - zpty_stop -0:Basic fg with subsequent user interaction -*>1 -*>zsh:*(stopped|suspended)*dc* -*>*continued*dc* -*>2 - - zpty_start - zpty_input $'dc 2>/dev/null\n1\np\n' - zpty_line - zpty_input $'\C-z' - zpty_input 'bg' - zpty_input 'fg' - zpty_input $'1\n+\np\nq\n' - zpty_stop -0:bg and fg with user input -*>1 -*>zsh:*(stopped|suspended)*dc* -*>*continued*dc* -*>*(stopped|suspended)*dc* -*>*continued*dc* -*>2 - %clean zmodload -ui zsh/zpty