mirrors/zsh
1
0
Fork 0
mirror of git://git.code.sf.net/p/zsh/code synced 2025-09-02 22:11:54 +02:00
Code Releases Activity

40817: __git_recent_branches: Retrieve less data, but faster.

Browse source 
By replacing the --grep-reflog=needle argument with a ${(M)...:#needle} filter,
we retrieve less data from the reflog, and consequently run (on my test cases)
16% to 40% faster.  The trade-off is that we retrieve less data: instead of
retrieving the 1000 most recent 'checkout' operations, we retrieve the most
recent 1000 operations, which would include fewer than 1000 checkout operations.

Also change [[:xdigit:]] to [0-9a-f] since it's faster, however, the absolute
gain from this is minor compared to the cost of 'git reflog'.
This commit is contained in:
Daniel Shahaf 2017-03-10 09:05:16 +00:00
parent 56ef4f62c4
commit 46233c4020
2 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
ChangeLog
View file

@ -1,5 +1,8 @@
2017-03-14 Daniel Shahaf <d.s@daniel.shahaf.name> 2017-03-14 Daniel Shahaf <d.s@daniel.shahaf.name>
* 40817: Completion/Unix/Command/_git: __git_recent_branches:
Retrieve less data, but faster.
* 40822: Doc/Zsh/contrib.yo: vcs_info quilt: Document the * 40822: Doc/Zsh/contrib.yo: vcs_info quilt: Document the
'.quilt-foo' zstyle context element. (Compare users/20807.) '.quilt-foo' zstyle context element. (Compare users/20807.)

3
Completion/Unix/Command/_git
View file

@ -6126,12 +6126,13 @@ __git_recent_branches__names()
# 2. Extracts the move-source from each # 2. Extracts the move-source from each
# 3. Eliminates duplicates # 3. Eliminates duplicates
# 4. Eliminates commit hashes (leaving only ref names) # 4. Eliminates commit hashes (leaving only ref names)
# [This step is done again by the caller.]
# #
# See workers/38592 for an equivalent long-hand implementation, and the rest # See workers/38592 for an equivalent long-hand implementation, and the rest
# of that thread for why this implementation was chosen instead. # of that thread for why this implementation was chosen instead.
# #
# Note: since we obtain the "from" part of the reflog, we only obtain heads, not tags. # Note: since we obtain the "from" part of the reflog, we only obtain heads, not tags.
reply=(${${(u)${${(0)"$(_call_program reflog git reflog -1000 -z --grep-reflog='\^checkout:\ moving\ from\ ' --pretty='%gs')"}#checkout: moving from }%% *}:#[[:xdigit:]](#c40)}) reply=(${${(u)${${(M)${(0)"$(_call_program reflog git reflog -1000 -z --pretty='%gs')"}:#(#s)checkout: moving from *}#checkout: moving from }%% *}:#[0-9a-f](#c40)})
} }
(( $+functions[__git_recent_branches] )) || (( $+functions[__git_recent_branches] )) ||