mirrors/zsh
1
0
Fork 0
mirror of git://git.code.sf.net/p/zsh/code synced 2025-10-17 12:41:14 +02:00
Code Releases Activity

26956: tidy up some zle variables for module unloading

Browse source 
note issue found on HP-UX
This commit is contained in:
Peter Stephenson 2009-05-11 09:03:25 +00:00
parent cfd3eab3d6
commit c18b6c2c99
3 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
ChangeLog
View file

@ -1,3 +1,10 @@
2009-05-11 Peter Stephenson <pws@csr.com>
* 26956: Etc/zsh-development-guide, Src/Zle/zle_refresh:
clear up region highlight variables properly and note that the
variables should be zeroed even if the module is being unloaded
(problem on HP-UX).
2009-05-09 Andrey Borzenkov <bor@zsh.org> 2009-05-09 Andrey Borzenkov <bor@zsh.org>
* unposted: Completion/Unix/Command/_getfacl: * unposted: Completion/Unix/Command/_getfacl:
@ -11684,5 +11691,5 @@
***************************************************** *****************************************************
* This is used by the shell to define $ZSH_PATCHLEVEL * This is used by the shell to define $ZSH_PATCHLEVEL
* $Revision: 1.4682 $ * $Revision: 1.4683 $
***************************************************** *****************************************************

4
Etc/zsh-development-guide
View file

@ -279,6 +279,10 @@ However, `finish_' is called even if `setup_' failed, so it should
not rely on the module successfully being set up. not rely on the module successfully being set up.
The state from `finish_' module is currently ignored; it is called The state from `finish_' module is currently ignored; it is called
too late to prevent the module from being unloaded. too late to prevent the module from being unloaded.
*Note* in addition to freeing memory, variables associated with allocated
memory should be set to NULL or to indicate arrays are empty, etc. It
should not be assumed that the variables will automatically be zeroed if
the module is reloaded (though some configurations may do this).
In short, the `cleanup_'-function should undo what the `boot_'-function did In short, the `cleanup_'-function should undo what the `boot_'-function did
(together with handling any residual effects of `enables_'), but should (together with handling any residual effects of `enables_'), but should

4
Src/Zle/zle_refresh.c
View file

@ -2644,6 +2644,10 @@ zle_refresh_finish(void)
freevideo(); freevideo();
if (region_highlights) if (region_highlights)
{
zfree(region_highlights, zfree(region_highlights,
sizeof(struct region_highlight) * n_region_highlights); sizeof(struct region_highlight) * n_region_highlights);
region_highlights = NULL;
n_region_highlights = 0;
}
} }