Trailing newlines are stripped from any attachments to PRs. This is a problem

commonly manifested by distinfo updates, where the file ends up without a
newline.  Newer versions of GNU patch also choke on such patches.

There is probably a more elegant solution than this, but given that GNATS
is not going to be with us for too long, we can rely on the behaviour of tools
to ignore any trailing newlines if they are added incorrectly [patch, shar].

http://lists.freebsd.org/pipermail/svn-ports-all/2013-February/012069.html

Anyone who can show that adding extra newlines to attachments causes breakage
is welcome to comment.

Bug noticed by:	ak, dougb
Approved by:	maintainer timeout (shaun, five months, multiple emails)
This commit is contained in:
Chris Rees 2013-02-18 20:56:52 +00:00
parent 4df778e422
commit 391471e01f
Notes: svn2git 2020-12-08 03:00:23 +00:00
svn path=/head/; revision=41011

View file

@ -198,6 +198,7 @@ sub main
$patch->filename;
print $patch->data;
print "\n";
Exit();
}