big refactoring

- `make install` should not depend on `make all'
- the local all-install target does not make any sense here.
  We should not install the target twice in different locations.
- the FORMATS value should be configurable and not hard coded
- fix update of pgpkeyring.txt

PR: 222828

en_US.ISO8859-1/htdocs/doc/Makefile

@@ -12,41 +12,28 @@
 .include "../Makefile.inc"
 .endif
 
-all: all-all all-install all-pgpkeyring
+_DOC_FORMATS?=	html-split html
+
+all: all-all all-pgpkeyring
 
 all-all:
-	@unset DESTDIR || true; \
+	${MAKE} -C ${DOC_PREFIX}/${LANGCODE} FORMATS="${_DOC_FORMATS}" all
-	 cd ${DOC_PREFIX}/${LANGCODE}; \
-		${MAKE} FORMATS="html-split html" \
-			INSTALL_COMPRESSED= all
-all-install:
-	@unset DESTDIR || true; \
-	 cd ${DOC_PREFIX}/${LANGCODE}; \
-		${MAKE} FORMATS="html-split html" DOCDIR=${.OBJDIR} \
-			INSTALL_COMPRESSED= install
-all-pgpkeyring:
-	@unset DESTDIR || true; \
-	 cd ${DOC_PREFIX}/share/pgpkeys; \
-		${MAKE} \
-			pgpkeyring > ${.OBJDIR}/pgpkeyring.txt
 
-install clean:
+all-pgpkeyring:
-	@unset DESTDIR || true; \
+	${MAKE} -C ${DOC_PREFIX}/share/pgpkeys pgpkeyring.txt
-	 cd ${DOC_PREFIX}/${LANGCODE}; \
+
-		${MAKE} FORMATS="html-split html" DOCDIR=${DESTDIR}/data/doc \
+clean:
-			INSTALL_COMPRESSED= ${.TARGET}
+	${MAKE} -C ${DOC_PREFIX}/${LANGCODE} FORMATS="${_DOC_FORMATS}" DOCDIR=${DESTDIR}/data/doc clean
-.if make(install)
+
-	@unset DESTDIR || true; \
+# here are dragons
-	 cd ${DOC_PREFIX}/share/pgpkeys; \
+install:
-		${MAKE} \
+	unset DESTDIR || true; \
-			pgpkeyring > ${DESTDIR}/data/doc/pgpkeyring.txt
+	  ${MAKE} -C ${DOC_PREFIX}/${LANGCODE} FORMATS="${_DOC_FORMATS}" DOCDIR=${DESTDIR}/data/doc install
-.endif
+	${CP} ${DOC_PREFIX}/share/pgpkeys/pgpkeyring.txt ${DESTDIR}/data/doc/pgpkeyring.txt
-.if make(clean)
-	${RM} -rf en* handbook faq pgpkeyring.txt
-.endif
 
 .include "${DOC_PREFIX}/share/mk/web.site.mk"
 
+# XXX
 obj: _OBJUSE
 
 _OBJUSE: .USE