From 6e07f0e5c96ea6de3eb20cefa9a0bff311d1ecd2 Mon Sep 17 00:00:00 2001 From: Doug Barton Date: Tue, 6 Dec 2011 02:16:09 +0000 Subject: [PATCH] Add 2 new items to the rc.d pre-commit checklist, do loops terminate, and use install instead of touch/chown/chmod. --- en_US.ISO8859-1/books/porters-handbook/book.sgml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/en_US.ISO8859-1/books/porters-handbook/book.sgml b/en_US.ISO8859-1/books/porters-handbook/book.sgml index 559f5b3416..608852d09f 100644 --- a/en_US.ISO8859-1/books/porters-handbook/book.sgml +++ b/en_US.ISO8859-1/books/porters-handbook/book.sgml @@ -8910,6 +8910,21 @@ run_rc_command "$1" All boolean tests should utilize the checkyesno function. No hand-rolled tests for [Yy][Ee][Ss], etc. + + + If there is a loop (for example, waiting for something to + start) does it have a counter to terminate the loop? We do + not want the boot to be stuck forever if there is an error. + + + + Does the script create files or directories that need + specific permissions, for example, a pid file that needs + to be owned by the user that runs the process? Rather than + the traditional touch/chown/chmod routine consider using + &man.install.1; with the proper command line arguments to + do the whole procedure with one step. +