From 7c67a5f6bb1009caddb051960800a8a03eec0ba2 Mon Sep 17 00:00:00 2001 From: "Jordan K. Hubbard" Date: Mon, 6 Sep 1999 22:51:27 +0000 Subject: [PATCH] Fix bogus mkstemp() reference. Spotted by: Jun Kuriyama --- en/security/advisories.xml | 10 +++++----- en/security/security.sgml | 10 +++++----- share/sgml/advisories.xml | 10 +++++----- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/en/security/advisories.xml b/en/security/advisories.xml index 82cc4338c1..3d92204e51 100644 --- a/en/security/advisories.xml +++ b/en/security/advisories.xml @@ -1,10 +1,10 @@ - + %includes; ]> - + &header; @@ -208,14 +208,14 @@ your program reads environment variables, be paranoid. Be very paranoid! is a symbolic link?"

-
  • Make sure to use mkstemp() instead of mktemp(), tempnam(), mkstemp() and -etc. Also make sure to look for races in /tmp in general, being aware that +
  • Make sure to use mkstemp() instead of mktemp(), tempnam(), etc. +Also make sure to look for races in /tmp in general, being aware that there are very few things which can be atomic in /tmp:
    • Creating a directory. This will either succeed or fail.
    • Opening a file O_CREAT | O_EXECL
    -If you use mkstemp - above cases will be properly handled for you. Hence +If you use mkstemp() - above cases will be properly handled for you. Hence all temp files should use mkstemp() to guarantee there is not race condition and that the permissions are correct.

    • diff --git a/en/security/security.sgml b/en/security/security.sgml index 82cc4338c1..3d92204e51 100644 --- a/en/security/security.sgml +++ b/en/security/security.sgml @@ -1,10 +1,10 @@ - + %includes; ]> - + &header; @@ -208,14 +208,14 @@ your program reads environment variables, be paranoid. Be very paranoid! is a symbolic link?"

    -
  • Make sure to use mkstemp() instead of mktemp(), tempnam(), mkstemp() and -etc. Also make sure to look for races in /tmp in general, being aware that +
  • Make sure to use mkstemp() instead of mktemp(), tempnam(), etc. +Also make sure to look for races in /tmp in general, being aware that there are very few things which can be atomic in /tmp:
    • Creating a directory. This will either succeed or fail.
    • Opening a file O_CREAT | O_EXECL
    -If you use mkstemp - above cases will be properly handled for you. Hence +If you use mkstemp() - above cases will be properly handled for you. Hence all temp files should use mkstemp() to guarantee there is not race condition and that the permissions are correct.

    • diff --git a/share/sgml/advisories.xml b/share/sgml/advisories.xml index 82cc4338c1..3d92204e51 100644 --- a/share/sgml/advisories.xml +++ b/share/sgml/advisories.xml @@ -1,10 +1,10 @@ - + %includes; ]> - + &header; @@ -208,14 +208,14 @@ your program reads environment variables, be paranoid. Be very paranoid! is a symbolic link?"

    -
  • Make sure to use mkstemp() instead of mktemp(), tempnam(), mkstemp() and -etc. Also make sure to look for races in /tmp in general, being aware that +
  • Make sure to use mkstemp() instead of mktemp(), tempnam(), etc. +Also make sure to look for races in /tmp in general, being aware that there are very few things which can be atomic in /tmp:
    • Creating a directory. This will either succeed or fail.
    • Opening a file O_CREAT | O_EXECL
    -If you use mkstemp - above cases will be properly handled for you. Hence +If you use mkstemp() - above cases will be properly handled for you. Hence all temp files should use mkstemp() to guarantee there is not race condition and that the permissions are correct.