os/doc
3
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix problem with dosendpr.cgi hanging after a PR has been submitted

Browse source 
where no page was returned to the submitter resulting in many
duplicate PR's.

The pipe to sendmail was just being closed without the nice ".\n" to
tell sendmail this is the end of the mail.  Now we always send "\n.\n"
to be sure the is a standalone "." on a line.

Why this wasn't a problem before, but is now, I'm not really sure, but
it's probably a perl 5.0 -> 5.8 change which triggered this.

If there are still problems after this commit, please report including
PR number(s).

Prodded by:			bugmeister(s)
Co-prodding and testing help:	edwin
Not fixed for far too long by:	simon
This commit is contained in:
Simon L. B. Nielsen 2007-05-23 21:53:45 +00:00
parent d6911e4aa7
commit 8e6bba0b80
Notes: svn2git 2020-12-08 03:00:23 +00:00 
svn path=/www/; revision=30222
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
en/cgi/dosendpr.cgi
View file

@ -8,7 +8,7 @@
# GNU General Public License Version 2.
# (http://www.gnu.ai.mit.edu/copyleft/gpl.html)
#
# $FreeBSD: www/en/cgi/dosendpr.cgi,v 1.29 2006/10/08 10:09:39 ceri Exp $
# $FreeBSD: www/en/cgi/dosendpr.cgi,v 1.30 2007/03/16 06:35:54 remko Exp $
use Socket;
use CGI qw/:standard/;
@ -209,6 +209,7 @@ $pr =~ s/\r//g;
if (open (SUBMIT, "|$submission_program")){
print SUBMIT $pr;
print SUBMIT "\n.\n";
close (SUBMIT);
print start_html("Thank you for the problem report");
print "<h1>Thank You</h1>",