Some clarifications regarding patches in PRs.
This commit is contained in:
parent
040dbf4621
commit
9dbfa73c50
Notes:
svn2git
2020-12-08 03:00:23 +00:00
svn path=/head/; revision=16288
1 changed files with 15 additions and 3 deletions
|
@ -214,10 +214,22 @@
|
|||
you modified so the developers who read your report will be
|
||||
able to apply them easily.</para>
|
||||
|
||||
<para>Note that while including small patches in a PR is
|
||||
generally all right, particularly when they fix the problem
|
||||
described in the PR, large patches and especially new code
|
||||
which may require substantial review before committing should
|
||||
be placed on a web or ftp server, and the URL should be
|
||||
included in the PR instead of the patch. Patches in email
|
||||
tend to get mangled, especially when Gnats is involved, and
|
||||
the larger the patch, the harder it will be for interested
|
||||
parties to unmangle it. Also, posting a patch on the web
|
||||
allows you to modify it without having to resubmit the entire
|
||||
patch in a followup to the original PR.</para>
|
||||
|
||||
<para>You should also take note that unless you explicitly
|
||||
specify otherwise in your PR, any patches you submit will be
|
||||
assumed to be licensed under the same terms as the original
|
||||
file you modified.</para>
|
||||
specify otherwise in your PR or in the patch itself, any
|
||||
patches you submit will be assumed to be licensed under the
|
||||
same terms as the original file you modified.</para>
|
||||
</section>
|
||||
|
||||
<section>
|
||||
|
|
Loading…
Reference in a new issue