From b3edeb15d04705b5882410c1e4d2643156d21d34 Mon Sep 17 00:00:00 2001 From: Wolfram Schneider Date: Wed, 1 Aug 2007 19:59:28 +0000 Subject: [PATCH] Disable option 'Closed reports too:' if no user input is given. For whatever reasons, the perl script query-pr-summary.cgi is horrible slow for large output. It take more than 4 CPU minutes to parse 100_000 lines text. It also doesn't make sense to generate a 20MB large HTML table. --- en/cgi/query-pr-summary.cgi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/en/cgi/query-pr-summary.cgi b/en/cgi/query-pr-summary.cgi index d68a53d2eb..b994674241 100755 --- a/en/cgi/query-pr-summary.cgi +++ b/en/cgi/query-pr-summary.cgi @@ -1,5 +1,5 @@ #!/usr/bin/perl -T -# $FreeBSD: www/en/cgi/query-pr-summary.cgi,v 1.57 2006/10/08 17:00:12 ceri Exp $ +# $FreeBSD: www/en/cgi/query-pr-summary.cgi,v 1.58 2007/01/10 17:47:39 danger Exp $ $html_mode = 1 if $ENV{'DOCUMENT_ROOT'}; $self_ref = $ENV{'SCRIPT_NAME'}; @@ -53,7 +53,8 @@ if ($html_mode) { } } -$closed_too = 1 if $input{'state'} eq 'closed' || $input{'closedtoo'}; +$closed_too = 1 if $input{'state'} eq 'closed' || + ($input{'closedtoo'} && ($input{'multitext'} || $input{'text'} || $input{'responsible'} || $input{'originator'})); #------------------------------------------------------------------------