From c5ff427774f7a869b9e7f42a506f068030cadd2d Mon Sep 17 00:00:00 2001 From: Mathieu Arnold Date: Thu, 6 Dec 2018 16:04:59 +0000 Subject: [PATCH] Move portmgr's blanket approval definition to the Committer's Guide, and shuffle a few things around. Reviewed by: bcr, adamw Differential Revision: https://reviews.freebsd.org/D18308 --- .../articles/committers-guide/article.xml | 47 +++++++++++++++++++ .../porters-handbook/makefiles/chapter.xml | 24 +++------- 2 files changed, 53 insertions(+), 18 deletions(-) diff --git a/en_US.ISO8859-1/articles/committers-guide/article.xml b/en_US.ISO8859-1/articles/committers-guide/article.xml index 73f7b4a684..70488425fe 100644 --- a/en_US.ISO8859-1/articles/committers-guide/article.xml +++ b/en_US.ISO8859-1/articles/committers-guide/article.xml @@ -4804,6 +4804,53 @@ Do you want to commit? (no = start a shell) [y/n] Miscellaneous Questions + + + Are there changes that can be committed without + asking the maintainer for approval? + + + + Blanket approval for most ports applies to these + types of fixes: + + + + Most infrastructure changes to a port (that is, + modernizing, but not changing the functionality). + For example, the blanket covers converting to new + USES macros, enabling verbose + builds, and switching to new ports system + syntaxes. + + + + Trivial and tested build + and runtime fixes. + + + + + Exceptions to this are anything maintained by the + &a.portmgr;, or the &a.security-officer;. No + unauthorized commits may ever be made to ports + maintained by those groups. + + + + Blanket approval does not apply to ports that are + maintained by teams like autotools@FreeBSD.org, x11@FreeBSD.org, gnome@FreeBSD.org, or kde@FreeBSD.org. These teams + use external repositories and can have work that would + conflict with changes that would normally fall under + blanket approval. + + + + How do I know if my port is building correctly or diff --git a/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml b/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml index c5b3668027..1c9e90ab9e 100644 --- a/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml +++ b/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml @@ -4050,24 +4050,12 @@ PATCHFILES= patch1:test with changes that would normally fall under blanket approval. - Blanket approval for most ports applies to these types of - fixes: - - - - Most infrastructure changes to a port (that is, - modernizing, but not changing the functionality). For - example, converting to staging, enabling verbose builds, - USE_GMAKE to - USES=gmake, the new - LIB_DEPENDS format... - - - - Trivial and tested build and - runtime fixes. - - + Blanket approval for most ports applies to fixes like + infrastructure changes, or trivial and + tested build and runtime fixes. The + current list is available in Ports + section of the Committer's Guide. Other changes to the port will be sent to the maintainer