Remove trailing "@" from team approval example in Committer's Guide,
plus incorporate additional content and formatting suggestions made by wblock. Differential Revision: https://reviews.freebsd.org/D3128 Reviewed by: wblock Approved by: doceng (wblock) Approved by: jmallett (mentor)
This commit is contained in:
parent
06855d0a7e
commit
e579c3b3cc
Notes:
svn2git
2020-12-08 03:00:23 +00:00
svn path=/head/; revision=47025
1 changed files with 8 additions and 7 deletions
|
|
@ -2489,16 +2489,17 @@ ControlPersist yes</screen>
|
|||
<emphasis>must</emphasis> be approved by the release
|
||||
engineering team.</para>
|
||||
|
||||
<para>If these are your first commits then you should have
|
||||
passed them past your mentor first, and you should list
|
||||
your mentor, as in
|
||||
``<replaceable>username-of-mentor</replaceable>
|
||||
<literal>(mentor)</literal>''.</para>
|
||||
<para>While under mentorship, get mentor approval before
|
||||
the commit. Enter the mentor's username in this field,
|
||||
and note that they are a mentor:</para>
|
||||
|
||||
<screen>Approved by: <userinput><replaceable>username-of-mentor</replaceable> <literal>(mentor)</literal></userinput></screen>
|
||||
|
||||
<para>If a team approved these commits then include the
|
||||
team name followed by the username of the approver in
|
||||
parentheses. For example: ``<replaceable>re@
|
||||
(username)</replaceable>``</para></entry>
|
||||
parentheses. For example:</para>
|
||||
|
||||
<screen>Approved by: <userinput><literal>re</literal> (<replaceable>username</replaceable>)</userinput></screen></entry>
|
||||
</row>
|
||||
|
||||
<row>
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue