to permit entering the code in lowercase (since the generator doesn't
generate lowercase letters).
Use a relative url to querypr-code.cgi so that mirrors (and test boxes)
can use the query-pr cgis unmodified.
The test for expired codes was inverted, so emptied the database every
time the test ran. Due to the time that the sweep was made, this bug
only hit the user if someone else had submitted a PR in the period
between their obtaining the code and submitting the PR.
This is likely the cause of the unexplained failures that some users
were seeing, which we all blamed on misbehaving caches.
that be an error or success), as it's not currently easy to find your
way back there. Suggested in:
PR: www/88473
Submitted by: Roman Neuhauser <neuhauser at sigpipe dot cz>
default. This has been a little wrong ever since these scripts moved to
docs.freebsd.org, but became very wrong when the style sheets were added
since docs.freebsd.org doesn't serve them.
1. If we're not running under cgi (for the mailindex run out of cron)
2. If we're running on docs.freebsd.org (because it doesn't have the
style files, and the "home" link would point to docs home, not
the home home)
3. If we're running on people.freebsd.org, to facilitate my testing
Otherwise, keep it relative for the benefit of mirrors.
docs problem pointed out by: Mark Trettin (mkt AT trettin DOT org)
It looks like Firefox applies the relative size twice, making the fonts
too small. Instead, now they'll be too big - just a bit bigger than
the "Large" web site font.
This only applies to HTML4 pages, which as I mentioned before are
cvsweb and mailindex, and I don't think that mailindex uses tables.
This means that this problem should be fixed when someone (no promises)
imports cvsweb 3 which uses XHTML.
This commit brought to you by CSS, Web Quirks, IE and our favorite IRC channel.
Add an optional 2nd argument to html_header(); if it's missing or
supplied and non-zero, html_header returns XHTML doctype; if it's
supplied and zero, html_header returns HTML 4.01 doctype.
cvsweb and mailindex are the only HTML4 holdouts. cvsweb should
be updated to 3.x which is XHTML, but that's a seperate step.
I left $hsty_home alone, because I couldn't find anything that used
it or any obvious image to use for it in the new layout.
and all the translations caught up. Except for es/support.sgml and
es/publish.sgml, but they are old. This also fixes a cleanup for
ceri which he started long time ago.
making it hard to copy/paste the originator field for PR issues.
Also make query-pr.cgi xhtml compliant.
Submitted by: Daniel Gerzo <danger at rulez dot sk>
pass the xhtml compliant check, making us conforming to standards.
This also finishes the update to query-pr-summary.cgi which is now
XHTML 1.0 compliant.
Submitted by: Daniel Gerzo <danger at rulez dot sk>
easier to read when you are using a color capable browser.
This will not impact a text-only browser.
Changes include:
o Code cleanup
o Add CSS style's.
o Use the new CSS style's.
o Move double quotes to quotes where needed.
o Made the HTML (except for the header) html-compliant.
The usage of CSS makes it easy to merge later when/if needed.
Discussed on: www@
No objections from: www@
Submitted by: Daniel Gerzo <danger at rulez dot sk>
o Clean some tagging.
PR: www/82379
Noticed by: Ed Schouten <ed@fxq.nl>
Submitted by: Daniel Gerzo <danger@rulez.sk>
Reviewed by: simon
Approved by: trhodes (mentor)
of problem report viewed through the web interface of query-pr to
bug-followup@freebsd.org to reduce the diffs from the problem-reports
articles and the potential for confusing our users.
Submitted by: Julien Gabel <jpeg@thilelli.net>
Forced commit also to reg.cgi to note that it can be cvs rm'd once all
of {es,fr,ja,ru}/register.sgml have caught up.
Approved by: silence on doc-committers@
some bugs of the text-mode listings of the Gnats database:
- Shave 2 characters out of the submission date, by removing the
enclosing [] pair.
- Increase the width of the tracker field. It should now be wide
enough until PR standards/999999 (which is, hopefully, a very
long time).
- Decrease the width of Resp. to 10 characters, as the longer name
is now a bit shorter (after the removal of 'freebsd-' a while
back).
- Shorten the 'Description' a bit, to keep the entire listing at
less than 79 columns (which IIRC was broken by me in revision
1.45, during the split of HTML/text output in separate functions).
- Handle that 6.0 also uses .tbz packages.
- Simply refer to the -STABLE/-CURRENT branches by their major number
so we don't have to update that part of the script for each release.
- 5-STABLE currently points to packages-5-current since there is no
packages-5-stable yet.
- Change the default version to 5-STABLE/i386.
the last suggestion of Jie Cao from www/69780:
``3. If we strip the spaces at the beginning of the lines, we
can reduce the size with a further 90000 bytes.''
PR: www/69780
Submitted by: Jie Cao (gaoj (at) cpsc (dot) ucalgary (dot) ca)
database queries once again, because I've received complaints that the
HTML output mode of the PR query scripts outputs huge, bloated tables
after the style changes I made to beautify HTML output.
This moves all the visual tweaks of the output in a CSS stylesheet and
add a $t_style option to the common cgi-style.pl script. If not set,
the style defaults to empty, but users of cgi-style.pl can set this to
a local CSS style like this:
$t_style="<style type=\"text/css\">...</style>";
or use it to refer from the header of the HTML output to an external
CSS stylesheet.
The HTML output size is substantially reduced now (at least 50% of the
size was caused by many repetitions of style="" attributes), but it's
still larger than the preformatted <pre> output because of all the
<tr> and <td> tags.
<TITLE>FreeBSD Hypertext Man Pages: tunefs(8)</TITLE>
they should be in the form
<TITLE>tunefs(8)</TITLE>
When a user has half a dozen tabs open in their browser, the tabs all
read "FreeBSD Hy...". If they read "tunefs(8)" instead, the user
could navigate much more quickly.
submitted by: Carleton Vaughn <keebler@mindspring.com>
characters in the confirmation image.
en/gifs/1.pnm and en/gifs/I.pnm will be safe to remove 45 minutes after
the next web build and not before, so I'll do that tomorrow.
PR: www/69676
- Use a <table> to align data for HTML output similar to the one used by
CVSweb to list directory contents. This helps the eye to pick the
right line to click on when picking PRs to read from a long list.
Approved by: ceri, linimon, simon, silence on -www
CVS, and use this by default. The CVS version is still used if the
local updated version isn't readable. On www.FreeBSD.org this means
that the updated INDEX(-5) found on
http://www.FreeBSD.porg/ports/INDEX(-5) are used.
In essence this mean that this CGI script is actually useful
again since it's not returning out-of-date results.
- Disable the "new ports" HTML since it just doesn't work without
frequent INDEX versions in CVS. The support code for this isn't
removed at this to avoid breaking stuff, but should be removed
later.
Testing opertunity provided by: kuriama
related to querying GNATS together, in order to aid with the upgrade to
GNATS 4.
Switch over dosendpr.cgi and query-pr.cgi to use it.
query-pr-summary.cgi to follow.
This code relies on the netpbm port being installed ; this is
already a dependency of the textproc/docproj port.
This comes courtesy of a collaboration with Eric Anderson
<anderson@centtech.com> who submitted both the idea and the vast
majority of the code to implement it; thank you very much, Eric - this
is a great Christmas present to us and our user community.
slow (1000x times) with the outdated perl 5.005_03 in
FreeBSD-4.x-stable. Depending on the number of hits, the html
output should now 2-30 seconds (!) faster.
freebsd-bugs already.
Add a micro-optimization to this test, which should just about make
up for checking two strings instead of one for most pr's.
Reviewed by: ceri
directory.
This fixes the problem reported several times on www@ when a port's
pkg-descr file is CVS deleted and INDEX isn't fully updated, then the
description link in ports.cgi will not work, because url.cgi can't the
pkg-descr file.
PR: www/53386
Submitted by: myself
Approved by: ceri (mentor)
* Remove FreeBSD 4.6-RELEASE.
* s/5.0-CURRENT/5.1-CURRENT/.
* s/4.7-STABLE/4.8-STABLE/.
* Use INDEX-5 for FreeBSD 5.x releases.
* Use .tbz packages for FreeBSD 5.x releases.
* Use CVS tags to find the correct INDEX version. This also makes
maintenance of this script simpler, since it does not have to know
about release dates.
* Do not use revision / date for -STABLE and -CURRENT (HEAD will contain
the needed INDEX version).
* Fix odd link to http://www.FreeBSD.org/ports/ instead of
mailto:www@freebsd.org (this was reported some time ago on the
www@freebsd.org mailing list).
PR: www/53381
Submitted by: myself
Approved by: ceri (mentor)
This avoid having the browser interpret <foo> as a HTML tag, which it
did for the port devel/pear-HTML_Select_Common.
Noticed by: Martin Jakob <m.jakob@gmx.net>
Approved by: ceri (mentor)
Reordered mirrors alphabetically.
Replaced ', ' with '/' in USA mirror for cleaner output.
PR: 38448
Submitted by: Alex Dupre <sysadmin@alexdupre.com>
Approved by: knu (mentor)
> Chinese. and I checked the source of man.cgi output, I think maybe add one
> line:
> <HTML>
> <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1"/>
>
> will avoid these type of browser auto charset detection error.
submitted by: "Che Dong" <chedong@yeah.net>
2002-05-22 Akinori MUSHA <knu@iDaemons.org>
* cvsweb.cgi: Read configuration files with `do' instead of
`require' to unbreak mod_perl support.
[Submitted by: "Khachaturov, Vassilii" <vassilii@tarunz.org>]
* cvsweb.cgi: Cosmetic fixes. Use and/or rather than &&/|| to
connect sentences.
* cvsweb.cgi: Exit with -1 if exec() fails.
* cvsweb.cgi: Do not print a redundant `Diff' for rev.1.1.
[Submitted by: Ville Skytt,Ad(B <ville.skytta@iki.fi>]
* cvsweb.cgi: Prevent cross-site scripting.
[Submitted by: Motoyuki Konno <motoyuki@bsdclub.org> (modified)]
* cvsweb.cgi: Skip a possible `locked by' clause and extract a
revision number out of a log entry properly.
[Submitted by: "Khachaturov, Vassilii" <vassilii@tarunz.org>]
* cvsweb.cgi: Apply some HTML cleanups and use CSS instead of
ancient HTML 3/4 tags and attributes.
[Submitted by: Ville Skytt,Ad(B <ville.skytta@iki.fi>]
* cvsweb.cgi: Pass `use' features to import to make it more memory
efficient.
[Submitted by: Ville Skytt,Ad(B <ville.skytta@iki.fi>]
* cvsweb.cgi: Add new configuration variables: $allow_log_extra,
$allow_dir_extra, and $allow_source_extra.
[Submitted by: "Khachaturov, Vassilii" <vassilii@tarunz.org>]
* cvsweb.cgi: Release as FreeBSD-cvsweb 2.0.2.
* cvsweb.cgi: Previous fixes against cross-site scripting
vulnerabilities were insufficient and buggy (error messages were
messed up). Revamp fatal() to HTML-quote automatically and fix
error message output.
* cvsweb.cgi: Release as FreeBSD-cvsweb 2.0.3.
2002-05-11 Akinori MUSHA <knu@iDaemons.org>
* cvsweb.cgi: There are no spaces at EOL in modern rlog output.
[Submitted by: "Khachaturov, Vassilii" <vassilii@tarunz.org>]
2002-05-08 Motoyuki Konno <motoyuki@FreeBSD.org>
* cvsweb.cgi: Fix a cross-site scripting vulnerablity.
2002-05-07 Akinori MUSHA <knu@iDaemons.org>
* cvsweb.conf-netbsd, cvsweb.conf-openbsd: NetBSD and OpenBSD
don't use $CVSHeader$ but $Id$.
[Submitted by: motoyuki@FreeBSD.org]
* cvsweb.cgi: Work around a bug of cvs -p; expand symlinks in a
cvsroot.
[Submitted by: motoyuki@FreeBSD.org]
* cvsweb.cgi: Fix parsing in 'tags' state.
[Submitted by: "Khachaturov, Vassilii" <vassilii@tarunz.org>]
in the headers. Although this information can be gleaned from the web
server logs, it should not be necessary to have access to the web
server in order to know who sent in a PR.
* Point ftp directory associated to -STABLE to $ftproot/packages-4-stable,
instead of $ftproot/packages-4.?-stable. When this file will be forgoten to be
updated next time it will not cause big problems.
* Remove 3.5-STABLE and 3.5-RELEASE from list of releases in search criteria
since ftp.FreeBSD.org no longer carry packages for this branch
* Add 4.3-RELEASE's INDEX time specification. Now request for 4.3-RELEASE
will return 4.3-RELEASE, not default.
* Also switch default release in search criteria to -STABLE to avoid
confusion of people who usually expect more recent information on
ports available for FreeBSD. Since -RELEASE criteria means using pors/INDEX
associated with exact release people never will see for new things until
manually change -RELEASE to -STABLE.
2002-04-11 Akinori MUSHA <knu@iDaemons.org>
* cvsweb.cgi, cvsweb.conf: Perform an HTML cleanup.
[Submitted by: Ville Skytt,Ad(B <ville.skytta@iki.fi>]
* cvsweb.cgi: Call this version FreeBSD-cvsweb 2.0.1.
2002-02-06 Akinori MUSHA <knu@iDaemons.org>
* cvsweb.cgi: Use TMPDIR instead of the hardcoded /tmp.
* cvsweb.cgi: Never pass 'MAIN' to cvs(1). 'HEAD' is the valid
tag.
* cvsweb.conf-freebsd: Allow downloading a tarball of a project
directory as well as a port directory.
* cvsweb.cgi, cvsweb.conf: Introduce optional output filter.
[Requested by: Shigeyuki Fukushima <shige@FreeBSD.org>]
* cvsweb.cgi: Fix a bug where it produces wrong download links when
cvsweb.cgi is placed right under the document root.
[Reported by: Arnaud on EFnet]
pull-down box that defaults to "All", but has options for
"Pre-5.x", "4.x", "5.x", "3.x" and "2.x".
Give query-pr.cgi the full PR path. This will allow a future
query-pr.cgi to skip looking through the whole GNATS index to
display a PR.
* Use make variables instead of hard coding commands, paths, and
options.
* Wrap some long lines.
* Replace shell loops with make for loops, etc.
PR: docs/31132
Submitted by: Cyrille Lefevre <clefevre@citeweb.net>
This allows us to search for all those PRs assigned to 're' without
adding the ones assigned to 'reg', or 'mi' and 'mike', etc.. Finally
I hope to have PR email that only contains the PRs that were really
meant for me.
2001-08-01 Akinori MUSHA <knu@iDaemons.org>
* cvsweb.cgi: perltidy -i=8 -t -pt=2 -bt=2 -sbt=2 -ci=4 -noll -sfs
-nasc -ce
* cvsweb.conf, cvsweb.conf-freebsd, cvsweb.conf-netbsd,
cvsweb.conf-openbsd, cvsweb.conf-ruby: perltidy -i=8 -t -pt=2 -bt=2
-sbt=2 -ci=4 -noll -sfs -nasc -ce
* cvsweb.cgi, cvsweb.conf: MFZ 1.111, but introduce @ForbiddenFiles
instead of @DissallowRead to forbid user to cvs
checkout/diff/annotate specified files.
* cvsweb.cgi: MFZ 1.112: A couple of trivial fixes.
2001-07-26 Akinori MUSHA <knu@iDaemons.org>
* cvsweb.cgi: Chdir to TMPDIR so it works even when the cgi-bin
directory is unreadable.
[Submitted by: Dmitry Morozovsky <marck@rinet.ru>]
* cvsweb.cgi: Let the module/path box appear and work properly
when there is only one repository.
[Submitted by: Dmitry Morozovsky <marck@rinet.ru>]
2001-07-06 Akinori MUSHA <knu@iDaemons.org>
* cvsweb.cgi, cvsweb.conf: Support "zip" as an additional
archiver.
* cvsweb.cgi: MFZ 1.110. But the bug had already been fixed in
knu-cvsweb.
2001-06-22 Akinori MUSHA <knu@iDaemons.org>
* cvsweb.cgi: Get rid of a potential "uninitialized variable
usage" warning.
[Submitted by: Bill Fenner <fenner@FreeBSD.org>]
2001-06-08 Akinori MUSHA <knu@iDaemons.org>
* cvsweb.cgi: MFZ 1.109. Preset the global variable the stores
the per file cvs info to avoid accumulating cruft under modperl.
this causes the $FreeBSD$ tags to get messed up. eg:
* $FreeBSD: /c/ncvs/src/sys/i386/include/globals.h,v 1.17 ... $
instead of the correct:
* $FreeBSD: src/sys/i386/include/globals.h,v 1.17 ... $
Change /home/ncvs to /c/ncvs in cvsweb.conf to compensate for this. :-(
This is a temporary hack. Something changed in cvsweb that broke this.
