output.
- Properly decode MIME parts from their source charset (in the case of
a single-part message, we haven't got the relevant headers thanks to
GNATS. Sigh.)
- Don't strip the trailing newline on MIME parts, as this breaks encoded
Quoted-Printable newlines (if there happened to be one at the end).
- Don't display S/MIME signatures [1]; reduce to the attachment link.
- Make the self-referencing-URL removal regex case insensitive.
Suggested by: gavin [1]
This is a significant improvement over the previous version, with more
robust patch handling, better encoding/charset handling, numerous
long-overdue bug fixes and a generally more maintainable codebase.
Content-Disposition header.
- When downloading/referring to a particular patch embed the patch
number with the PR instead of using two different CGI variables.
This means that there aren't "&" in the patch URL's anymore which
makes things simpler for sh(1) like shells, by not requiring quoting
of URLs when using a command line tool, such as fetch(1), to
download patches.
- In HTML-ifying of URL's, handle when a URL contains a PR like string
which can e.g. be seen in PR www/113071.
- Add a comment about how to test script via the command line.
Submitted by: edwin, shaun
PR: www/113071
This work included:
- move a few functions out of query-pr-summary.cgi into a new file -
query-pr-lib.pl, which now provides a procedure to display forms
- include query-pr-lib.pl in both query-pr.cgi and query-pr-summary.cgi
scripts
PR: www/35647
Approved by: trhodes (mentor), keramida (mentor)
Silence from: www@
couldn't specify full PR ID, e.g., bin/12345, in the
"PR number" field of the web form because the slash
was encoded as %2F by many browsers. Of course,
decoding the query is a must for a cgi in general.
- Also allow queries like query-pr.cgi?q= and query-pr.cgi?cat/num
- Fix comment
- Display query form when no results found
- Allow some other characters to be part of the URL [1]
PR: www/103628 [1]
Reviewed by: simon, remko
Approved by: keramida (mentor)
- A multi-line mail header wrapping on a space wasn't handled correctly.
- My attempt at finding the end of patches with no delimiter inside
replies wasn't working in some cases; I've disabled it for now.
This was written from scratch, and offers numerous enhancements over the
old script; notably:
- Patches are parsed, coloured, uudecoded, and downloadable.
- Cleaner, clearer layout.
- Easier-to-read Audit-Trail.
Reviewed by: freebsd-www (well, I tried...)
Approved by: simon
to permit entering the code in lowercase (since the generator doesn't
generate lowercase letters).
Use a relative url to querypr-code.cgi so that mirrors (and test boxes)
can use the query-pr cgis unmodified.
that be an error or success), as it's not currently easy to find your
way back there. Suggested in:
PR: www/88473
Submitted by: Roman Neuhauser <neuhauser at sigpipe dot cz>
making it hard to copy/paste the originator field for PR issues.
Also make query-pr.cgi xhtml compliant.
Submitted by: Daniel Gerzo <danger at rulez dot sk>
o Clean some tagging.
PR: www/82379
Noticed by: Ed Schouten <ed@fxq.nl>
Submitted by: Daniel Gerzo <danger@rulez.sk>
Reviewed by: simon
Approved by: trhodes (mentor)
of problem report viewed through the web interface of query-pr to
bug-followup@freebsd.org to reduce the diffs from the problem-reports
articles and the potential for confusing our users.
Submitted by: Julien Gabel <jpeg@thilelli.net>
related to querying GNATS together, in order to aid with the upgrade to
GNATS 4.
Switch over dosendpr.cgi and query-pr.cgi to use it.
query-pr-summary.cgi to follow.
