fef/ardix
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

printf: don't ignore return value of last write()

Browse source
This commit is contained in:
anna 2021-08-01 19:04:03 +02:00
parent 4db1702078
commit c81ea7e7fd
Signed by: fef
GPG key ID: EC22E476DC2D3D84
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
lib/printf.c
View file

@ -43,12 +43,15 @@ static struct printf_buf *printf_buf_create(int fd)
return buf; return buf;
} }
static void printf_buf_destroy(struct printf_buf *buf) static ssize_t printf_buf_destroy(struct printf_buf *buf)
{ {
ssize_t ret = 0;
if (buf->len != 0) if (buf->len != 0)
write(buf->fd, &buf->data[0], buf->len); ret = write(buf->fd, &buf->data[0], buf->len);
free(buf); free(buf);
return ret;
} }
static ssize_t printf_buf_write(struct printf_buf *buf, const void *data, size_t len) static ssize_t printf_buf_write(struct printf_buf *buf, const void *data, size_t len)
@ -241,7 +244,9 @@ int vfprintf(FILE *f, const char *fmt, va_list args)
if (tmp != fmt && ret >= 0) if (tmp != fmt && ret >= 0)
ret += printf_buf_write(buf, fmt, (size_t)tmp - (size_t)fmt); ret += printf_buf_write(buf, fmt, (size_t)tmp - (size_t)fmt);
printf_buf_destroy(buf); ssize_t tmpret = printf_buf_destroy(buf);
if (tmpret < 0)
ret = tmpret;
return (int)ret; return (int)ret;
} }