fef/libneo
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

string: sanitize nstrcmp return value on error

Browse source
This commit is contained in:
anna 2021-07-16 14:43:02 +02:00
parent a1ac5d8c41
commit 66032c95f2
Signed by: fef
GPG key ID: EC22E476DC2D3D84
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/string/nstrcmp.c
View file

@ -11,13 +11,21 @@
int nstrcmp(const string *s1, const string *s2, error *err) int nstrcmp(const string *s1, const string *s2, error *err)
{ {
/*
* Return values are always undefined if an error was yeeted so it's not
* strictly necessary to return a correct(ish) result here, but the
* philosophy of libneo is to always behave in a way that is the least
* harmful.
*/
if (s1 == nil) { if (s1 == nil) {
yeet(err, EFAULT, "First string is nil"); yeet(err, EFAULT, "First string is nil");
return 0; if (s2 == nil)
return 0;
return -1;
} }
if (s2 == nil) { if (s2 == nil) {
yeet(err, EFAULT, "Second string is nil"); yeet(err, EFAULT, "Second string is nil");
return 0; return 1;
} }
int ret; int ret;