Use unchanging github links in docs/comments (#29545)
parent
c10bbf5fe3
commit
a38e424185
@ -1,10 +1,7 @@
|
||||
# frozen_string_literal: true
|
||||
|
||||
# TODO
|
||||
# Starting with Rails 7.0, the framework default here is to set this true.
|
||||
# However, we have a location in devise that redirects where we don't have an
|
||||
# easy ability to override the method or set a config option, and where the
|
||||
# redirect does not supply this option itself.
|
||||
# https://github.com/heartcombo/devise/blob/v4.9.2/app/controllers/devise/confirmations_controller.rb#L28
|
||||
# Once a solution is found, this line can be removed.
|
||||
# TODO: Starting with Rails 7.0, the framework default is true for this setting.
|
||||
# This location in devise redirects and we can't hook in or override:
|
||||
# https://github.com/heartcombo/devise/blob/v4.9.3/app/controllers/devise/confirmations_controller.rb#L28
|
||||
# When solution is found, this setting can go back to default.
|
||||
Rails.application.config.action_controller.raise_on_open_redirects = false
|
||||
|
@ -1,6 +1,6 @@
|
||||
inherit_from: ../../.rubocop.yml
|
||||
|
||||
# Anonymous controllers in specs cannot access described_class
|
||||
# https://github.com/rubocop/rubocop-rspec/blob/master/lib/rubocop/cop/rspec/described_class.rb#L36-L39
|
||||
# Anonymous controllers in specs cannot access `described_class`, explanation:
|
||||
# https://github.com/rubocop/rubocop-rspec/blob/v2.26.1/lib/rubocop/cop/rspec/described_class.rb#L36-L56
|
||||
RSpec/DescribedClass:
|
||||
SkipBlocks: true
|
||||
|
Loading…
Reference in New Issue