Fix link verifications when page size exceeds 1MB (#29358)

3 months ago · f25414014a
parent b0822ae9cd
commit f25414014a
2 changed files with 8 additions and 7 deletions
--- a/app/services/verify_link_service.rb
+++ b/app/services/verify_link_service.rb
@ -19,7 +19,7 @@ class VerifyLinkService < BaseService

  def perform_request!
    @body = Request.new(:get, @url).add_headers('Accept' => 'text/html').perform do |res|
-      res.code == 200 ? res.body_with_limit : nil
+      res.code == 200 ? res.truncated_body : nil
    end
  end

--- a/spec/services/verify_link_service_spec.rb
+++ b/spec/services/verify_link_service_spec.rb
@ -80,24 +80,25 @@ RSpec.describe VerifyLinkService, type: :service do
        "
          <!doctype html>
          <body>
-            <a rel=\"me\" href=\"#{ActivityPub::TagManager.instance.url_for(account)}\"
+            <a rel=\"me\" href=\"#{ActivityPub::TagManager.instance.url_for(account)}\">
        "
      end

-      it 'marks the field as not verified' do
-        expect(field.verified?).to be false
+      it 'marks the field as verified' do
+        expect(field.verified?).to be true
      end
    end

-    context 'when a link back might be truncated' do
+    context 'when a link tag might be truncated' do
      let(:html) do
        "
          <!doctype html>
          <body>
-            <a rel=\"me\" href=\"#{ActivityPub::TagManager.instance.url_for(account)}"
+            <a rel=\"me\" href=\"#{ActivityPub::TagManager.instance.url_for(account)}\"
+        "
      end

-      it 'does not mark the field as verified' do
+      it 'marks the field as not verified' do
        expect(field.verified?).to be false
      end
    end