Add 2 new items to the rc.d pre-commit checklist, do loops terminate,

and use install instead of touch/chown/chmod.
This commit is contained in:
Doug Barton 2011-12-06 02:16:09 +00:00
parent d5795b93d1
commit 6e07f0e5c9
Notes: svn2git 2020-12-08 03:00:23 +00:00
svn path=/head/; revision=38004

View file

@ -8910,6 +8910,21 @@ run_rc_command "$1"</programlisting>
<para>All boolean tests should utilize the checkyesno function.
No hand-rolled tests for [Yy][Ee][Ss], etc.</para>
</step>
<step>
<para>If there is a loop (for example, waiting for something to
start) does it have a counter to terminate the loop? We do
not want the boot to be stuck forever if there is an error.</para>
</step>
<step>
<para>Does the script create files or directories that need
specific permissions, for example, a pid file that needs
to be owned by the user that runs the process? Rather than
the traditional touch/chown/chmod routine consider using
&man.install.1; with the proper command line arguments to
do the whole procedure with one step.</para>
</step>
</procedure>
</sect2>
</sect1>