os/doc
3
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Move portmgr's blanket approval definition to the Committer's Guide, and

Browse source 
shuffle a few things around.

Reviewed by:	bcr, adamw
Differential Revision:	https://reviews.freebsd.org/D18308
This commit is contained in:
Mathieu Arnold 2018-12-06 16:04:59 +00:00
parent 8e549f630c
commit c5ff427774
Notes: svn2git 2020-12-08 03:00:23 +00:00 
svn path=/head/; revision=52611
2 changed files with 53 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

47
en_US.ISO8859-1/articles/committers-guide/article.xml
View file

@ -4804,6 +4804,53 @@ Do you want to commit? (no = start a shell) [y/n]</screen>
<qandadiv xml:id="ports-qa-misc-questions">
<title>Miscellaneous Questions</title>
<qandaentry xml:id="ports-qa-misc-blanket-approval">
<question>
<para>Are there changes that can be committed without
asking the maintainer for approval?</para>
</question>
<answer>
<para>Blanket approval for most ports applies to these
types of fixes:</para>
<itemizedlist>
<listitem>
<para>Most infrastructure changes to a port (that is,
modernizing, but not changing the functionality).
For example, the blanket covers converting to new
<varname>USES</varname> macros, enabling verbose
builds, and switching to new ports system
syntaxes.</para>
</listitem>
<listitem>
<para>Trivial and <emphasis>tested</emphasis> build
and runtime fixes.</para>
</listitem>
</itemizedlist>
<important>
<para>Exceptions to this are anything maintained by the
&a.portmgr;, or the &a.security-officer;. No
unauthorized commits may ever be made to ports
maintained by those groups.</para>
</important>
<warning>
<para>Blanket approval does not apply to ports that are
maintained by teams like <email
role="nolink">autotools@FreeBSD.org</email>, <email
role="nolink">x11@FreeBSD.org</email>, <email
role="nolink">gnome@FreeBSD.org</email>, or <email
role="nolink">kde@FreeBSD.org</email>. These teams
use external repositories and can have work that would
conflict with changes that would normally fall under
blanket approval.</para>
</warning>
</answer>
</qandaentry>
<qandaentry xml:id="ports-qa-misc-correctly-building">
<question>
<para>How do I know if my port is building correctly or

24
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
View file

@ -4050,24 +4050,12 @@ PATCHFILES= patch1:test</programlisting>
with changes that would normally fall under blanket
approval.</para>
<para>Blanket approval for most ports applies to these types of
fixes:</para>
<itemizedlist>
<listitem>
<para>Most infrastructure changes to a port (that is,
modernizing, but not changing the functionality). For
example, converting to staging, enabling verbose builds,
<varname>USE_GMAKE</varname> to
<literal>USES=gmake</literal>, the new
<varname>LIB_DEPENDS</varname> format...</para>
</listitem>
<listitem>
<para>Trivial and <emphasis>tested</emphasis> build and
runtime fixes.</para>
</listitem>
</itemizedlist>
<para>Blanket approval for most ports applies to fixes like
infrastructure changes, or trivial and
<emphasis>tested</emphasis> build and runtime fixes. The
current list is available in <link
xlink:href="&url.articles.committers-guide;/ports.html#ports-qa-misc-blanket-approval">Ports
section of the Committer's Guide</link>.</para>
</note>
<para>Other changes to the port will be sent to the maintainer