Commit graph

39 commits

Author SHA1 Message Date
Shaun Amott
f00aeeb94e Revert last change; the PR viewer can handle the old patch format now; but
having delimiters as causes other problems.
2008-01-26 22:49:57 +00:00
Shaun Amott
b035d48107 Add some delimiters around patches, to match the behaviour of send-pr and make
parsing easier.
2008-01-26 15:22:33 +00:00
Remko Lodder
0eed2951f1 Bump version level for dosendpr.cgi
Requested by:	ceri
2007-08-08 12:06:29 +00:00
Remko Lodder
77c387fca3 Add the X-Notify-GNATS: header when we send a PR through the webinterface,
the GNATS auto assign script uses this to add the maintainer of a port
to the PR.

PR:		115290
Submitted by:	Edwin
2007-08-08 11:30:57 +00:00
Ceri Davies
ad29bd2c03 Try harder to get people to use a .txt extension, since Firefox insists
on sending application/octet-stream otherwise.

Prodded by: 	sem
2007-08-06 12:16:17 +00:00
Simon L. B. Nielsen
36700687bc Add missing space in From when "building" the PR.
Submitted by:	shaun
PR:		www/113071
Hijacked unrelated PR for patch:	shaun
2007-06-12 20:03:05 +00:00
Ceri Davies
ac8c88109f Accept shar files.
PR:		www/113609
2007-06-12 06:14:34 +00:00
Ceri Davies
6a79bf9903 Correct whitespace issue in error output. 2007-06-12 06:06:41 +00:00
Simon L. B. Nielsen
8e6bba0b80 Fix problem with dosendpr.cgi hanging after a PR has been submitted
where no page was returned to the submitter resulting in many
duplicate PR's.

The pipe to sendmail was just being closed without the nice ".\n" to
tell sendmail this is the end of the mail.  Now we always send "\n.\n"
to be sure the is a standalone "." on a line.

Why this wasn't a problem before, but is now, I'm not really sure, but
it's probably a perl 5.0 -> 5.8 change which triggered this.

If there are still problems after this commit, please report including
PR number(s).

Prodded by:			bugmeister(s)
Co-prodding and testing help:	edwin
Not fixed for far too long by:	simon
2007-05-23 21:53:45 +00:00
Remko Lodder
bf645a9416 Specify what Content-Type we send, and what the script was expecting to
get.

PR:		www/110285
Submitted by:	Devon H. O'Dell <devon dot odell at coyotepoint dot com>
Silence on:	www@
2007-03-16 06:35:54 +00:00
Ceri Davies
e76f60e1c6 We really don't have a recent perl on www, despite things I have read to
contrary.
2006-10-08 10:09:39 +00:00
Ceri Davies
8759cd186a Bump version number and move a newline back to where it came from. 2006-10-07 18:12:16 +00:00
Ceri Davies
9231a0d249 Allow patches to be attached via the web page.
Thanks to Marius Nuennerich for submitting the idea and for never giving
up on nagging me about it.

PR:		www/83397
2006-10-07 18:08:04 +00:00
Ceri Davies
54ca30ff53 Convert dosendpr.cgi from html.pl to CGI.pm.
This will allow us to use multipart forms without rolling our own MIME
parser.
2006-10-07 14:07:46 +00:00
Simon L. B. Nielsen
451acb67a8 Move the sendpr verification "database" to a non world-writeable
directory.

OK'ed by:	ceri
2005-12-04 22:25:20 +00:00
Bill Fenner
a7613f7a01 Turn the entered code uppercase before looking it up in the database,
to permit entering the code in lowercase (since the generator doesn't
 generate lowercase letters).
Use a relative url to querypr-code.cgi so that mirrors (and test boxes)
 can use the query-pr cgis unmodified.
2005-11-16 23:35:57 +00:00
Ceri Davies
23aa9b9807 Correct a bug regarding the expiration of codes.
The test for expired codes was inverted, so emptied the database every
time the test ran.  Due to the time that the sweep was made, this bug
only hit the user if someone else had submitted a PR in the period
between their obtaining the code and submitting the PR.

This is likely the cause of the unexplained failures that some users
were seeing, which we all blamed on misbehaving caches.
2005-11-06 22:07:23 +00:00
Ceri Davies
bc33ecc9ba Add some decent markup to the output of dosendpr.cgi.
The prerror class added to freebsd.css is not currently used; this will
happen once dosendpr.cgi is converted to use cgi-style.pl rather than
html.pl.
2005-07-14 11:26:17 +00:00
Ceri Davies
f08bb99ab7 Add an embryonic Gnats.pm that will collect variables and subroutines
related to querying GNATS together, in order to aid with the upgrade to
GNATS 4.

Switch over dosendpr.cgi and query-pr.cgi to use it.
query-pr-summary.cgi to follow.
2004-02-16 16:57:10 +00:00
Ceri Davies
84cbdf31c8 Remove some commented out debugging code. 2004-02-16 16:54:06 +00:00
Ceri Davies
1644d55106 Remove checks for files that do not exist, and garbage collect more
variables.
2004-02-16 16:49:25 +00:00
Ceri Davies
55282681c2 Bump the send-pr version header port r1.17. 2004-02-16 14:41:30 +00:00
Ceri Davies
b38382e9a8 Have dosendpr.cgi clean up after itself, rather than having a separate
script to do the job.

Suggested by:	wosch
2004-02-16 14:38:05 +00:00
Ceri Davies
62ba1925fa Remove duplicated text. 2004-02-16 14:34:23 +00:00
Ceri Davies
e107d98123 Up the length of time for which a code remains valid from 15 minutes to
45 minutes.  This was partially prompted by:

PR:		www/60668
Submitted by:	Kevin Ross <austusross@yahoo.com>
2004-01-03 21:24:51 +00:00
Ceri Davies
555cb01e5a Re-enable the web-based PR submission mechanism.
This code relies on the netpbm port being installed ; this is
already a dependency of the textproc/docproj port.

This comes courtesy of a collaboration with Eric Anderson
<anderson@centtech.com> who submitted both the idea and the vast
majority of the code to implement it; thank you very much, Eric - this
is a great Christmas present to us and our user community.
2003-12-14 17:28:13 +00:00
Ceri Davies
00ca5bfab5 The RBL at osirusoft.com no longer operates, so use dnsbl.njabl.org instead. 2003-09-04 15:16:15 +00:00
Ceri Davies
3fe1d85edc Correct some user visible typo's. 2003-05-15 12:08:05 +00:00
Ceri Davies
5ae2caabf6 Like the warning says:
"Scalar value @_[0] better written as $_[0] at dosendpr.cgi line 70."
2002-11-02 01:22:44 +00:00
Ceri Davies
e613525131 Log as much information about the submitter as the web server will give us.
Reviewed by:	kuriyama
2002-11-02 01:21:41 +00:00
Ceri Davies
9d293da917 Refuse access to the interface for machines listed in relays.osirusoft.com.
Insert a header and allow access to unverified hosts should the lookup have
problems.

Suggested by:	Thread on -developers
Approved by:	silence on -www
2002-10-05 12:17:19 +00:00
Dima Dorfman
0ea6a64950 Be a good web email interface and include the originator's IP address
in the headers.  Although this information can be gleaned from the web
server logs, it should not be necessary to have access to the web
server in order to know who sent in a PR.
2002-05-20 07:14:41 +00:00
Chris Costello
abaaf7562d Use the `originator' field in the From: line instead of the
`synopsis' field.
2001-06-13 20:36:59 +00:00
Dima Dorfman
0e78c11047 Put the originator's name in the From: field. 2001-06-13 00:04:42 +00:00
Wolfram Schneider
dbd8ba9a85 Disallow GET requests. 2001-05-07 19:28:09 +00:00
Wolfram Schneider
f39b1e916c typo in last commit 2000-11-29 13:48:17 +00:00
Wolfram Schneider
1b334d6405 better argument checking 2000-11-29 13:39:37 +00:00
Alexey Zelkin
4ab24069fa Add $FreeBSD$ tags 2000-04-03 08:45:51 +00:00
Ade Barkah
cae4a77425 To unify all the cgi scripts under one directory in the repository. 1997-01-04 19:54:51 +00:00