os
/
kern
5
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

bits: remove unnecessary xor

Browse Source
main
anna 3 years ago
parent 16a229c936
commit e561adbb6f
Signed by: fef
GPG Key ID: EC22E476DC2D3D84
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File

4
kernel/bits.c
Unescape Escape View File

@ -14,7 +14,7 @@ void bit_set_range(unsigned long *bitfield, usize first, usize count)
/* test if the entire bit range is contained within this longword */ /* test if the entire bit range is contained within this longword */
if (bit + count < LONG_BIT) { if (bit + count < LONG_BIT) {
unsigned long low_mask = (1lu << bit) - 1; /* 0b000..011 */ unsigned long low_mask = (1lu << bit) - 1; /* 0b000..011 */
unsigned long high_mask = ~0lu ^ ((1lu << (bit + count)) - 1); /* 0b110..000 */ unsigned long high_mask = ~( (1lu << (bit + count)) - 1 ); /* 0b110..000 */
*bitfield |= ~(low_mask | high_mask); *bitfield |= ~(low_mask | high_mask);
} else { } else {
/* if the first bit isn't longword aligned, manually set the upper /* if the first bit isn't longword aligned, manually set the upper
@ -47,7 +47,7 @@ void bit_clr_range(unsigned long *bitfield, usize first, usize count)
if (bit + count < LONG_BIT) { if (bit + count < LONG_BIT) {
unsigned long low_mask = (1lu << bit) - 1; unsigned long low_mask = (1lu << bit) - 1;
unsigned long high_mask = ~0lu ^ ((1lu << (bit + count)) - 1); unsigned long high_mask = ~( (1lu << (bit + count)) - 1 );
*bitfield &= low_mask | high_mask; *bitfield &= low_mask | high_mask;
} else { } else {
if (bit != 0) { if (bit != 0) {

Write Preview
Loading…
Cancel
Save